Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm drawer config consumer props #17390

Merged
merged 2 commits into from
Jul 4, 2019
Merged

rm drawer config consumer props #17390

merged 2 commits into from
Jul 4, 2019

Conversation

jljsj33
Copy link
Member

@jljsj33 jljsj33 commented Jul 1, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 删除 drawer props 里的 ConfigConsumerProps，fix #17387

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@jljsj33 jljsj33 requested a review from afc163 July 1, 2019 08:26
@netlify
Copy link

netlify bot commented Jul 1, 2019 •
edited
Loading

Deploy preview for ant-design ready!

Built with commit c020797

https://deploy-preview-17390--ant-design.netlify.com

afc163
afc163 reviewed Jul 1, 2019
View reviewed changes
components/drawer/index.tsx
getPrefixCls,
renderEmpty,
csp,
autoInsertSpaceInButton,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样以后 ConfigProvider 加东西还会出现，@zombieJ 看看有没有更好的办法。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我一般用到什么加什么，rest 会有点多……

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样以后加个属性，又会有一堆报错。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以抽一个库处理 dom attr，传递给 dom 前 omit 掉不用的。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能否 withConfigConsumer 加个参数，声明组件用到的 props，这样后续 ConfigProvider 加属性不会影响到已有组件。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

类似于 originProps 这种吗？

@zombieJ
Copy link
Member

zombieJ commented Jul 2, 2019

CI 挂了

@jljsj33
Copy link
Member Author

jljsj33 commented Jul 3, 2019

这 CI 是报的哪门子错啊？？？

@zombieJ
Copy link
Member

zombieJ commented Jul 3, 2019

在 style/index.tsx 里加一个：

// deps-lint-skip: empty

ConfigProvider + renderEmpty 命中了 empty 的 rule，以为用到了 Empty 组件……

@codecov
Copy link

codecov bot commented Jul 3, 2019 •
edited
Loading

Codecov Report

Merging #17390 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17390   +/-   ##
=======================================
  Coverage   96.03%   96.03%           
=======================================
  Files         267      267           
  Lines        7414     7414           
  Branches     2067     2065    -2     
=======================================
  Hits         7120     7120           
  Misses        292      292           
  Partials        2        2
Impacted Files Coverage Δ
components/drawer/index.tsx 98.71% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d87bff6...c020797. Read the comment docs.

@bytemain bytemain mentioned this pull request Jul 4, 2019
Closed
1 task
@zombieJ zombieJ merged commit a129846 into master Jul 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the drawer-props branch July 4, 2019 12:54
@yutingzhao1991 yutingzhao1991 mentioned this pull request Jul 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ left review comments

@afc163 afc163 afc163 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

更新到3.20.0后，Drawer 抽屉报错
3 participants
@jljsj33 @zombieJ @afc163