chore: 🆙 upgrade react-slick and eslint-config-airbnb #18209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
Deploy preview for ant-design ready! Built with commit 9095189 |
afc163
commented
Aug 11, 2019
| @@ -56,6 +56,8 @@ const eslintrc = { | |||
| 'jsx-a11y/anchor-is-valid': 0, | |||
| 'comma-dangle': ['error', 'always-multiline'], | |||
| 'react/jsx-filename-extension': 0, | |||
| 'react/state-in-constructor': 0, | |||
There was a problem hiding this comment.
这个感觉是应该要改掉的，contructor 里面通过 props 取 state 初始值的逻辑都可以合并到 getDerivedStateFromProps 里。
afc163
changed the title
afc163
changed the title
afc163
changed the title
afc163
commented
Aug 11, 2019
package.json
Outdated
| @@ -90,7 +90,7 @@ | |||
| "rc-util": "^4.6.0", | |||
| "react-lazy-load": "^3.0.13", | |||
| "react-lifecycles-compat": "^3.0.4", | |||
| "react-slick": "~0.24.0", | |||
| "react-slick": "~0.25.0", | |||
There was a problem hiding this comment.
afc163
force-pushed
the
eslint-config-airbnb
branch
from
5006c01 to
ce89fb6
Compare
Codecov Report
@@ Coverage Diff @@
## master #18209 +/- ##
==========================================
- Coverage 96.32% 96.28% -0.04%
==========================================
Files 276 276
Lines 7520 7520
Branches 2048 2048
==========================================
- Hits 7244 7241 -3
- Misses 274 277 +3
Partials 2 2
Continue to review full report at Codecov.
|
|
akiran/react-slick@97988e8#diff-84b66437c6b7a9ed244642c3423bee13R130 broken React 15 test case. |
afc163
force-pushed
the
eslint-config-airbnb
branch
from
30ff7c3 to
d37af41
Compare
afc163
force-pushed
the
eslint-config-airbnb
branch
from
d37af41 to
9095189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge