fix: Cascader className duplicate #27187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eea9df1:
|
Codecov Report
@@ Coverage Diff @@
## master #27187 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 389 389
Lines 7392 7392
Branches 2021 2070 +49
=========================================
Hits 7392 7392
Continue to review full report at Codecov.
|
yoyo837
reviewed
Oct 16, 2020
| 'expandIcon', | ||
| 'loadingIcon', | ||
| 'bordered', | ||
| 'className', |
There was a problem hiding this comment.
Why not omit it from the input?
There was a problem hiding this comment.
考虑过这个，本来没必要从input里面加，但是偏偏加了，我觉得可能是有意这样做的，没考虑太多，所以就直接从props里面omit了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #27168
💡 Background and solution
📝 Changelog
CascaderclassName duplicateCascader类名重复☑️ Self Check before Merge