Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extend switch component #20

Merged
merged 2 commits into from
Jul 18, 2022
Merged

refactor: extend switch component #20

merged 2 commits into from
Jul 18, 2022

Conversation

hafsahayath
Copy link
Contributor

Description

  • extend the switch component to accepting native props

Motivation and Context

  • allow switch component to accept native checkbox input functionalities

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@hafsahayath hafsahayath requested a review from pruthvi2103 July 18, 2022 05:49
@vercel
Copy link

vercel bot commented Jul 18, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hover-design ✅ Ready (Inspect) Visit Preview Jul 18, 2022 at 11:30AM (UTC)

@netlify
Copy link

netlify bot commented Jul 18, 2022 •
edited
Loading

✅ Deploy Preview for hover-design canceled.

Name Link
🔨 Latest commit 7428b1f
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/62d5442e5cb0ce0008345aa0

@netlify
Copy link

netlify bot commented Jul 18, 2022 •
edited
Loading

✅ Deploy Preview for enchanting-stroopwafel-5222c6 canceled.

Name Link
🔨 Latest commit 7428b1f
🔍 Latest deploy log https://app.netlify.com/sites/enchanting-stroopwafel-5222c6/deploys/62d5442e02d4760009e5adce

pruthvi2103
pruthvi2103 approved these changes Jul 18, 2022
View reviewed changes
lib/src/components/Switch/Switch.tsx Outdated Show resolved Hide resolved
@pruthvi2103
Copy link
Contributor

LGTM, merging

@pruthvi2103 pruthvi2103 merged commit ec5b3a7 into main Jul 18, 2022
@pruthvi2103 pruthvi2103 mentioned this pull request Jul 28, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pruthvi2103 pruthvi2103 pruthvi2103 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hafsahayath @pruthvi2103