Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(theme): add transblue #1201

Closed
wants to merge 3 commits into from
Closed

Conversation

Hephaest
Copy link

Hi @anuraghazra,

I provide a reasonable and compatible theme for both light and dark modes. Thanks for reviewing the PR.

@vercel
Copy link

vercel bot commented Jul 22, 2021

@Hephaest is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the themes Feature, Enhancement, Fixes related to themes. label Jul 22, 2021
@anuraghazra
Copy link
Owner

Theme preview (bot)

title_color: #1d87da | icon_color: #539bf5 | text_color: #539bf5 | bg_color: #0000

Link: https://github-readme-stats.vercel.app/api?username=anuraghazra&title_color=1d87da&icon_color=539bf5&text_color=539bf5&bg_color=0000&show_icons=true

Hi thanks for the theme contribution, please read our theme contribution guidelines

We are currently only accepting color combinations from any vscode theme or which has good color combination to minimize bloating the themes collection.

Also note that if this theme is exclusively for your personal use then instead of adding it to our theme collection you can use card customization options

Read our contribution guidelines for more info

@Hephaest
Copy link
Author

One of acceptable solutions for Discussion #690 and #1010.

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 2, 2022

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ transblue

Result: ✔️ All themes are valid.

Details

Transblue theme preview

title_color: #1d87da | icon_color: #539bf5 | text_color: #539bf5 | bg_color: #0000

Preview Link

@Hephaest
Copy link
Author

Hephaest commented Oct 2, 2022

Hi @rickstaa, seems like I need your help to approve running workflows before merging the PR. Can you help me out? Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2022

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ transblue

Result: ✔️ All themes are valid.

Details

Transblue theme preview

title_color: #1d87da | icon_color: #539bf5 | text_color: #539bf5 | bg_color: #0000

Preview Link

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@5d42af5). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1201   +/-   ##
=========================================
  Coverage          ?   97.41%           
=========================================
  Files             ?       22           
  Lines             ?     3487           
  Branches          ?      316           
=========================================
  Hits              ?     3397           
  Misses            ?       89           
  Partials          ?        1           
Impacted Files Coverage Δ
themes/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 2, 2022

@Hephaest Thanks for your theme PR. I just ran the improved theme-preview action that's why you received a message. It looks like your theme is good to merge. However, we have more than 100 themes open, so we are currently only merging themes that receive several upvotes or that are based on very popular Vscode themes. I will keep this PR open so that we can track how much interest there is in your theme.

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 2, 2022

Ah, I just saw that you have a transparent theme. We decided that we will provide one transparent theme for now (see #1001 (comment)). The others people can create by changing the background to transparent.

[![Anurag's GitHub stats](https://github-readme-stats.vercel.app/api?username=anuraghazra&theme=default&bg_color=ffff&show_icons=true)](https://github.com/anuraghazra/github-readme-stats)

Anurag's GitHub stats

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 2, 2022

I will close this for now. I will re-open if we change this in the future.

@rickstaa rickstaa closed this Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
themes Feature, Enhancement, Fixes related to themes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants