Fix total commits not counting by year #788
Conversation
|
@aboqasem is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
| // since totalCommitsFetcher already sends totalCommits no need to += | ||
| if (include_all_commits) { | ||
| if (!include_all_commits) { |
There was a problem hiding this comment.
If include_all_commits is true.. we should fetch all of the commits since user joined github.
There was a problem hiding this comment.
But that is already done above, isn't it? So the code is fetching the same info again.
After I modified the code, /api/?username=aboqasem&include_all_commits=true renders the expected output:
As well as /api/?username=aboqasem:
Could you explain further what am I missing here?
Thank you!
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This fixes #778, fixes #787. But I don't know if the modified code will break something.
I think it should not because
if(!include_all_commits)meansNOT all commits, but yearly commits.Not sure, so feel free to correct me if I'm wrong 😅.