can not ban LegacyVersion yet

anza-xyz · Feb 4, 2025 · 814abfa · 814abfa
1 parent 97b5712
commit 814abfa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/gossip/src/crds_data.rs b/gossip/src/crds_data.rs
@@ -89,7 +89,7 @@ impl Sanitize for CrdsData {
                 }
                 val.sanitize()
             }
-            CrdsData::LegacyVersion(_) => Err(SanitizeError::InvalidValue),
+            CrdsData::LegacyVersion(version) => version.sanitize(),
             CrdsData::Version(version) => version.sanitize(),
             CrdsData::NodeInstance(node) => node.sanitize(),
             CrdsData::DuplicateShred(ix, shred) => {

diff --git a/gossip/src/protocol.rs b/gossip/src/protocol.rs
@@ -160,18 +160,9 @@ impl Sanitize for Protocol {
                 }
             }
             Protocol::PullResponse(_, val) => {
-                // PullResponse is allowed to carry anything in its CrdsData, except for deprecated fields
-                for v in val {
-                    match v.data() {
-                        CrdsData::LegacyVersion(_) => {
-                            return Err(SanitizeError::InvalidValue);
-                        }
-                        _ => {
-                            v.sanitize()?;
-                        }
-                    }
-                }
-                Ok(())
+                // PullResponse is allowed to carry anything in its CrdsData, including deprecated Crds
+                // such that a deprecated Crds does not get pulled and then rejected.
+                val.sanitize()
             }
             Protocol::PushMessage(_, val) => {
                 //Push is allowed to carry anything in its CrdsData, except for deprecated fields