Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loaded-account-data-size-cost to qos metric #1369

Conversation

tao-stones
Copy link

Problem

loaded_accounts_data_size_cost are not reported to metric.

Summary of Changes

  • add it to qos metric table

Fixes #

@tao-stones tao-stones requested review from apfitzge and bw-solana May 15, 2024 15:07
Copy link

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bw-solana
Copy link

backport to v1.18?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.1%. Comparing base (aa2f078) to head (cf79b71).
Report is 120 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #1369     +/-   ##
=========================================
- Coverage    82.1%    82.1%   -0.1%     
=========================================
  Files         886      886             
  Lines      236417   236431     +14     
=========================================
- Hits       194266   194237     -29     
- Misses      42151    42194     +43     

@tao-stones
Copy link
Author

backport to v1.18?

It'd report 0 until #1356 is merged/bp-ed. Maybe backport after #1356?

@tao-stones tao-stones merged commit e86ab5a into anza-xyz:master May 15, 2024
38 checks passed
@tao-stones tao-stones deleted the imp-add-loaded-accounts-data-size-cost-to-metric branch May 15, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants