Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move solana-program to dev deps of solana-bpf-loader-program #4766

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

move solana-program to dev deps of solana-bpf-loader-program #4766

wants to merge 2 commits into from
+49 −22

Conversation

kevinheavey
Copy link

Problem

This crate no longer needs all of solana-program

Summary of Changes

  • Replace with component crates
  • Inline three consts from solana_program::syscalls to avoid having solana-program as a normal dep. Add tests to ensure they match what's in solana-program

@mergify Mergify
Copy link

mergify bot commented Feb 3, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@kevinheavey kevinheavey marked this pull request as ready for review February 3, 2025 22:50
@kevinheavey kevinheavey requested a review from a team as a code owner February 3, 2025 22:50
@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Feb 4, 2025
LucasSte
LucasSte reviewed Feb 4, 2025
View reviewed changes
programs/bpf_loader/src/syscalls/cpi.rs
static_assertions::const_assert_eq!(
MAX_CPI_ACCOUNT_INFOS,
solana_program::syscalls::MAX_CPI_ACCOUNT_INFOS
);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have an assertion here during tests, I believe the change must be fine. @Lichtso do you have any opinion on this?

@mergify Mergify
Copy link

mergify bot commented Feb 4, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasSte LucasSte LucasSte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinheavey @LucasSte