Merge branch 'main' into release/1.0.2

README.md

@@ -3,7 +3,7 @@
 [![Format code](https://github.com/aoki-h-jp/bybit-bulk-downloader/actions/workflows/Formatter.yml/badge.svg)](https://github.com/aoki-h-jp/bybit-bulk-downloader/actions/workflows/Formatter.yml)
 [![Run pytest on all branches](https://github.com/aoki-h-jp/bybit-bulk-downloader/actions/workflows/pytest.yaml/badge.svg)](https://github.com/aoki-h-jp/bybit-bulk-downloader/actions/workflows/pytest.yaml)
 
-## ## Python library for bulk downloading bybit historical data
+## Python library for bulk downloading bybit historical data
 A Python library to efficiently and concurrently download historical data files from bybit. Supports all asset types (spot, USDT Perpetual, Inverse Perpetual & Inverse Futures).
 
 ## Installation
@@ -77,4 +77,4 @@ instruments in this or in any other jurisdiction in which such solicitation or o
 securities laws of such jurisdiction.
 
 Under no circumstances will I be held responsible or liable in any way for any claims, damages, losses, expenses, costs,
-or liabilities whatsoever, including, without limitation, any direct or indirect damages for loss of profits.
+or liabilities whatsoever, including, without limitation, any direct or indirect damages for loss of profits.

bybit_bulk_downloader/downloader.py

@@ -16,7 +16,7 @@
 
 class BybitBulkDownloader:
     _CHUNK_SIZE = 20
-    _BYBIT_DATA_DOWNLOAD_BASE_URL = "https://public.bybit.com/"
+    _BYBIT_DATA_DOWNLOAD_BASE_URL = "https://public.bybit.com"
     _DATA_TYPE = ("kline_for_metatrader4", "premium_index", "spot_index", "trading")
 
     def __init__(self, destination_dir=".", data_type="trading"):
@@ -33,7 +33,7 @@ def _get_url_from_bybit(self):
         Get the URL of the data to download from Bybit.
         :return: list of URLs to download.
         """
-        url = "https://public.bybit.com/" + self._data_type + "/"
+        url = self._BYBIT_DATA_DOWNLOAD_BASE_URL + "/" + self._data_type + "/"
         response = requests.get(url)
         soup = BeautifulSoup(response.text, "html.parser")
         symbol_list = []

requirements.txt

@@ -1,4 +1,5 @@
 requests~=2.28.2
 setuptools~=68.1.2
 rich~=10.16.2
-pytest~=4.6.11
+pytest~=4.6.11
+beautifulsoup4~=4.12.2

setup.py

@@ -2,9 +2,9 @@
 
 setup(
     name="bybit-bulk-downloader",
-    version="1.0.0",
+    version="1.0.1",
     description=" Python library to efficiently and concurrently download historical data files from Binance. Supports all asset types (spot, USDT-M, COIN-M, options) and all data frequencies.",
-    install_requires=["requests", "rich", "pytest", "bs4"],
+    install_requires=["requests", "rich", "pytest", "beautifulsoup4"],
     author="aoki-h-jp",
     author_email="[email protected]",
     license="MIT",