Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropRight can result in OutOfMemoryExceptions being thrown #1012

Closed
johnmcclean opened this issue Jan 28, 2019 · 2 comments
Closed

dropRight can result in OutOfMemoryExceptions being thrown #1012

johnmcclean opened this issue Jan 28, 2019 · 2 comments
Labels
bug
Milestone
10.2.0

Comments

@johnmcclean
Copy link
Member

e.g. This results in OOM error

 assertThat(LazyString.of("hello world").dropRight(Integer.MAX_VALUE),equalTo(empty));

This can be solved by checking if the size of the String (or List) is less than max value.
@johnmcclean johnmcclean added this to the 10.2.0 milestone Jan 28, 2019
@johnmcclean
Copy link
Member Author

Related to #1013

@johnmcclean johnmcclean mentioned this issue Jan 28, 2019
Closed
johnmcclean added a commit that referenced this issue Jan 28, 2019
@johnmcclean
add tests and impls for #1012 and #1013
4328dc6
@johnmcclean
Copy link
Member Author

Merged in #1016

johnmcclean added a commit that referenced this issue May 20, 2022
@johnmcclean
add tests and impls for #1012 and #1013
8a6848a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
10.2.0
Development

No branches or pull requests
1 participant
@johnmcclean