Skip to content

Commit

Permalink
[chrome.angle] Force Pure RISCV64 Support on Android
Browse files Browse the repository at this point in the history
Utilize the definition of skip_secondary_abi_for_cq and android_secondary_abi_toolchain directly to support pure RISCV64 on Android.

Before RISCV64 introduced into Chromium, every 64-bit ARCH enables its own 32-bit support by default.
But for RISCV, Android announced only pure 64-bit would be supported.
So for Chromium RISCV64 on Android, one proposed solution based on the commit is to skip the legacy check logic for its 32-bit ABI.

Signed-off-by: McKnight22 <[email protected]>
  • Loading branch information
McKnight22 authored and unicornx committed Apr 3, 2023
1 parent d12176e commit 937ede4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions android/angle_apk.gni
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@ if (enable_java_templates) {
deps = [ ":${invoker.package_name}_assets" ]
if (symbol_level != 0) {
deps += [ ":compressed_symbols" ]
if (android_64bit_target_cpu) {
if (android_64bit_target_cpu && defined(android_secondary_abi_toolchain)) {
deps += [ ":compressed_symbols($android_secondary_abi_toolchain)" ]
}
}

uncompress_shared_libraries = true

if (android_64bit_target_cpu) {
if (android_64bit_target_cpu && defined(android_secondary_abi_toolchain)) {
if (symbol_level == 0) {
secondary_abi_shared_libraries = []
foreach(_library, angle_libraries) {
Expand Down

0 comments on commit 937ede4

Please sign in to comment.