This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix(legacy-preset-chart-nvd3): redraw markers after legend interaction #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
approved these changes
Mar 4, 2019
nytai
referenced
this pull request
in preset-io/superset-ui-plugins
Apr 27, 2020
#6) * fix(legacy-preset-chart-nvd3): redraw markers after legend interaction * fix: lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
In the
NVD3Vis, markers are drawn only the first time the chart is rendered. Because of this, if you re-toggle a line interacting with the legend it will be redrawn without markers.I fixed by adding an event listener on changes to the chart. Unfortunately,
nvd3calls the dispatch before the line is drawn, so I had to add a small delay (10ms) in order for it to work. I couldn't find a better way of doing this, and since the viz is being deprecated I didn't want to spend too much time on this.