Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error upgrading to exec-maven-plugin version 3.1.0 #3033

Closed
DomGarguilo opened this issue Oct 19, 2022 · 3 comments · Fixed by #3426
Closed

Error upgrading to exec-maven-plugin version 3.1.0 #3033

DomGarguilo opened this issue Oct 19, 2022 · 3 comments · Fixed by #3426
Labels
bug This issue has been verified to be a bug.
Milestone

Comments

@DomGarguilo
Copy link
Member

Describe the bug
When updating the exec-maven-plugin version to 3.1.0 in the pom, the build fails with mkdir: missing operand. I'm pretty sure this comes from here:

accumulo/core/pom.xml

Lines 344 to 348 in 78142d7

<executable>mkdir</executable>
<arguments>
<argument>-p</argument>
<argument>${project.build.directory}/generated-docs</argument>
</arguments>

The second argument must not be behaving as expected. I can replicate this error in my terminal by not passing another argument i.e. mkdir -p with nothing after it.

Versions (OS, Maven, Java, and others, as appropriate):

  • Affected version(s) of this project: 2.1.0-SNAPSHOT

To Reproduce
Steps to reproduce the behavior (or a link to an example repository that reproduces the problem):

  1. udpate exec-maven-plugin to 3.1.0
  2. run mvn clean package -DskipTests
@DomGarguilo DomGarguilo added the bug This issue has been verified to be a bug. label Oct 19, 2022
@ctubbsii
Copy link
Member

I wonder if it is related to mojohaus/exec-maven-plugin#334 , which also seems related to mojohaus/exec-maven-plugin#75 . exec-maven-plugin seems to perpetually be confused regarding anything with -p, due to assumptions that it's related to a Java modulepath, even if the executable is entirely different.

It would be good to just put in an inline XML comment like the one we used to have for 1.6.0:

<!-- version 1.6.0 is broken; see https://github.com/mojohaus/exec-maven-plugin/issues/75 -->

@Manno15
Copy link
Contributor

Manno15 commented Oct 29, 2022

Just for context, the workarounds others have suggested in the ticket do work. Both "-p" and --parents

@ctubbsii
Copy link
Member

Just for context, the workarounds others have suggested in the ticket do work. Both "-p" and --parents

I'd rather wait for the upstream bug to be fixed, rather than use these workarounds. Hacking the quote parsing for the short option seems fragile, and using the long option won't work on non-GNU systems like BSD. There's no reason the plugin should be doing anything with the arguments passed to the executable at all. We can leave this at the current version for now.

ctubbsii added a commit to ctubbsii/accumulo that referenced this issue May 25, 2023
Reduce warnings at the end of the build from using Maven 3.9.2 by
updating several plugins whose versions are specified in the parent POM
to the latest, which resolves the warnings from Maven. Specifically,
update maven-resources-plugin, maven-compiler-plugin, exec-maven-plugin,
apilyzer-maven-plugin, maven-dependency-plugin, and
maven-enforcer-plugin.

Update some dependency declarations, based on new detections from latest
version of maven-dependency-plugin (specifically, zookeeper-jute in
minicluster and libthrift in the monitor).

Updating exec-maven-plugin required addressing apache#3033 with a workaround,
and testing the script added for that workaround caught some additional
shellcheck issues in the assembly module's cluster management scripts
(unreachable redundant exit command) and generate-thrift.sh (unquoted
path variable). So those fixes are included here as well.

This fixes apache#3033.
ctubbsii added a commit that referenced this issue May 25, 2023
Reduce warnings at the end of the build from using Maven 3.9.2 by
updating several plugins whose versions are specified in the parent POM
to the latest, which resolves the warnings from Maven. Specifically,
update maven-resources-plugin, maven-compiler-plugin, exec-maven-plugin,
apilyzer-maven-plugin, maven-dependency-plugin, and
maven-enforcer-plugin.

Update some dependency declarations, based on new detections from latest
version of maven-dependency-plugin (specifically, zookeeper-jute in
minicluster and libthrift in the monitor).

Updating exec-maven-plugin required addressing #3033 with a workaround,
and testing the script added for that workaround caught some additional
shellcheck issues in the assembly module's cluster management scripts
(unreachable redundant exit command) and generate-thrift.sh (unquoted
path variable). So those fixes are included here as well.

This fixes #3033.
asfgit pushed a commit that referenced this issue Aug 14, 2023
Reduce warnings at the end of the build from using Maven 3.9.2 by
updating several plugins whose versions are specified in the parent POM
to the latest, which resolves the warnings from Maven. Specifically,
update maven-resources-plugin, maven-compiler-plugin, exec-maven-plugin,
apilyzer-maven-plugin, maven-dependency-plugin, and
maven-enforcer-plugin.

Update some dependency declarations, based on new detections from latest
version of maven-dependency-plugin (specifically, zookeeper-jute in
minicluster and libthrift in the monitor).

Updating exec-maven-plugin required addressing #3033 with a workaround,
and testing the script added for that workaround caught some additional
shellcheck issues in the assembly module's cluster management scripts
(unreachable redundant exit command) and generate-thrift.sh (unquoted
path variable). So those fixes are included here as well.

This fixes #3033.
@ctubbsii ctubbsii added this to the 2.1.2 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue has been verified to be a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants