Remove negative value from server idle #5061
Open
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a sum aggregator for metric queries, the possible negative value removes values causing graphing issues. Removes the startup value of the service (-1) in favor of reporting an initial error state.
dlmarion
approved these changes
Nov 14, 2024
| } | ||
|
|
||
| public double getIdleAsDouble(ProcessMetrics processMetrics) { |
There was a problem hiding this comment.
can we just make this an int? There are two possible values and both are whole numbers.
There was a problem hiding this comment.
We could. The Gauge.builder is going to convert it to a double but we could use an int beforehand and let the builder deal with the conversion.
There was a problem hiding this comment.
The previous code returned an int, which is why I asked. If Micrometer is just turning that into a double, then what you have is fine. Thanks!
keith-turner
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a sum aggregator for metric queries, the possible negative value removes values causing graphing issues.
Removes the startup value of the service (-1) in favor of reporting an initial error state.