ARTEMIS-5304 Allow delayed close of federation consumers #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabish121
force-pushed
the
amqp-federation-delay-receiver-close
branch
from
6b082db to
35cd587
Compare
|
I was expecting some documentation for this new setting, but I couldn't find it. Was that an oversight or does this not need any user-facing docs? |
As follow work for this plus many other updates there will need to be rework of the federation docs but that's a bit out of scope here. The defaults on this should suffice for the majority of users as this should be transparent in practice. |
gemmellr
reviewed
Feb 13, 2025
...rg/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederationConfiguration.java
Outdated
Show resolved
Hide resolved
tabish121
force-pushed
the
amqp-federation-delay-receiver-close
branch
from
35cd587 to
79ef2f4
Compare
When demand is removed from a federation consumer and the AMQP link is drained allow the consumer to idle for a configurable time period before closing the link. If demand returns before the idled link is closed we can recover the link by simply granting more credit.
tabish121
force-pushed
the
amqp-federation-delay-receiver-close
branch
from
79ef2f4 to
df4658c
Compare
|
I've squashed the changes and rebased with main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When demand is removed from a federation consumer and the AMQP link is drained allow the consumer to idle for a configurable time period before closing the link. If demand returns before the idled link is closed we can recover the link by simply granting more credit.