Skip to content

Commit

Permalink
Temporarily limits WTForms to below 3.2.0 (#43233) (#43234)
Browse files Browse the repository at this point in the history
WTForms are limited to 3.2.0 because of the error in tests. We technically do not need it directly
as this is a dependency of Flask-WTF, but we need to specify it here to add the limitation
The issue to track it is https://github.com/pallets-eco/wtforms/issues/863
Note. 3.2.0 has been broken because of imports pallets-eco/wtforms#861 which
was fixed in 3.2.1, but after import was fixed, the tests started to work with 3.2.1
when the issue 863 is fixed, we should likely leave the line below and specify !=3.2.0,!=3.2.1

(cherry picked from commit 979d750)

Co-authored-by: Jarek Potiuk <[email protected]>
  • Loading branch information
jscheffl and potiuk authored Oct 21, 2024
1 parent 7fc49eb commit 7daa556
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion hatch_build.py
Original file line number Diff line number Diff line change
Expand Up @@ -435,9 +435,16 @@
"dill>=0.2.2",
"flask-caching>=2.0.0",
# Flask-Session 0.6 add new arguments into the SqlAlchemySessionInterface constructor as well as
# all parameters now are mandatory which make AirflowDatabaseSessionInterface incopatible with this version.
# all parameters now are mandatory which make AirflowDatabaseSessionInterface incompatible with this version.
"flask-session>=0.4.0,<0.6",
"flask-wtf>=1.1.0",
# WTForms are limited to 3.2.0 because of the error in tests. We technically do not need it directly
# as this is a dependency of Flask-WTF, but we need to specify it here to add the limitation
# The issue to track it is https://github.com/pallets-eco/wtforms/issues/863
# Note. 3.2.0 has been broken because of imports https://github.com/pallets-eco/wtforms/issues/861 which
# was fixed in 3.2.1, but after import was fixed, the tests started to work with 3.2.1
# when the issue 863 is fixed, we should likely leave the line below and specify !=3.2.0,!=3.2.1
"wtforms>=3.1.0,<3.2.0",
# Flask 2.3 is scheduled to introduce a number of deprecation removals - some of them might be breaking
# for our dependencies - notably `_app_ctx_stack` and `_request_ctx_stack` removals.
# We should remove the limitation after 2.3 is released and our dependencies are updated to handle it
Expand Down

0 comments on commit 7daa556

Please sign in to comment.