Improve graph view refresh #16696
Merged
Improve graph view refresh #16696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only refresh if state has actually changed - stop refresh if all states are final - swap out `.attr()` to `.prop()` for handling `checked` see https://stackoverflow.com/questions/5874652/prop-vs-attr
boring-cyborg
bot
added
area:UI
ashb
reviewed
Jun 29, 2021
airflow/www/static/js/graph.js
Outdated
Comment on lines
383
to
388
| state === null | ||
| || state === 'running' | ||
| || state === 'scheduled' | ||
| || state === 'queued' | ||
| || state === 'up_for_retry' | ||
| || state === 'up_for_reschedule' |
There was a problem hiding this comment.
We should invert this -- there are fewer terminal states (and less chance of us adding any new ones - we added a new on in #16681 for instance)
So something like
Suggested change
| state === null | |
| || state === 'running' | |
| || state === 'scheduled' | |
| || state === 'queued' | |
| || state === 'up_for_retry' | |
| || state === 'up_for_reschedule' | |
| ["success", "failed", "upstream_failed", "skipped", "removed"].indexOf(state) !== -1 |
ryanahamilton
approved these changes
Jul 8, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #15879 to make graph view refresh better.
only refresh if state has actually changed
stop refresh if all states are final. By stopping the refresh automatically, the user doesn't need to do it manually and disabling autorefresh in the future.
swap out
.attr()to.prop()for handlingcheckedsee https://stackoverflow.com/questions/5874652/prop-vs-attr^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.