Warn if Python changes are not rebased #21016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are introducing this change temporary to make sure that Python changes will not accidentally introduce new MyPy errors after we merge them. This check might be disabled ~week after we enable MyPy as failing check.
kaxil
approved these changes
Jan 21, 2022
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 29, 2022
The up-to-date check for Python run for ~week so all the PRs raised in the last week will need to be rebased to account for MyPy changes. Hopefully there will be no more PRs from before, that have not been rebased (we had one serious MyPy problem for the apache#20077 change that was approved before the up-to-date checker was enabled in apache#21016
potiuk
added a commit
that referenced
this pull request
Jan 29, 2022
The up-to-date check for Python run for ~week so all the PRs raised in the last week will need to be rebased to account for MyPy changes. Hopefully there will be no more PRs from before, that have not been rebased (we had one serious MyPy problem for the #20077 change that was approved before the up-to-date checker was enabled in #21016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are introducing this change temporary to make sure that Python
changes will not accidentally introduce new MyPy errors after we
merge them.
This check might be disabled ~week after we enable MyPy as failing
check.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.