Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #21096: Support boolean in extra__snowflake__insecure_mode #21155

Merged
merged 3 commits into from
Jan 28, 2022

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Jan 27, 2022

closes: #21096


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question for the isintance check

@mik-laj mik-laj requested a review from potiuk January 28, 2022 10:29
@potiuk
Copy link
Member

potiuk commented Jan 28, 2022

Only transient problems. merging.

@potiuk potiuk merged commit 534e9ae into apache:main Jan 28, 2022
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jan 28, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@raeray
Copy link

raeray commented Apr 25, 2022

hello! new to airflow - i am currently using airflow 2.1.0 and hvae this problem. how can i incorporate this solution into my airflow version?

@potiuk
Copy link
Member

potiuk commented Apr 25, 2022

If you can't upgrade Airflow (recommended), you can individually upgrade snowflake provider to version that has it fixed: https://airflow.apache.org/docs/apache-airflow-providers-snowflake/stable/index.html - to find out which version will be good for you.

You have a number of upgrade scenarios described here for PyPI case, https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-pypi.html#installation-and-upgrade-scenarios , but the actual scanario for you depends on deployment of yours - whether you use an image, or virtualenv or others, you just need to upgrade the snowflake provider package in your deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:snowflake Issues related to Snowflake provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snowflake connection, boolean value of extra__snowflake__insecure_mode interpreted as string
3 participants