Store grid view selection in url params #23290
Conversation
boring-cyborg
bot
added
area:UI
|
CC: @staufferl16 |
| @@ -27,5 +27,8 @@ export default function useTasks(dagId) { | |||
| return useQuery( | |||
| ['tasks', dagId], | |||
| () => axios.get(tasksUrl), | |||
| { | |||
| placeholderData: { tasks: [] }, | |||
There was a problem hiding this comment.
Is this argument a default return value for the useQuery function?
There was a problem hiding this comment.
Yes, but it doesn't affect the cache https://react-query.tanstack.com/guides/placeholder-query-data
| @@ -42,13 +42,13 @@ const Wrapper = ({ children }) => { | |||
| <ContainerRefProvider value={{}}> | |||
| <TimezoneProvider value={{ timezone: 'UTC' }}> | |||
| <AutoRefreshProvider value={{ isRefreshOn: false, stopRefresh: () => {} }}> | |||
| <SelectionProvider value={{ onSelect: () => {}, selected: {} }}> | |||
| <MemoryRouter> | |||
There was a problem hiding this comment.
Why do we use MemoryRouter here but BrowserRouter elsewhere?
Does MemoryRouter mean that components here don't change the URL, right?
There was a problem hiding this comment.
Yes, tests aren't run on an actual browser so we use a different router.
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
* Add url params for dag_run_id and task_id * Persist other search params * simplify useSelection * delete extra params * remove API change (cherry picked from commit 4c1fcee)
* Add url params for dag_run_id and task_id * Persist other search params * simplify useSelection * delete extra params * remove API change (cherry picked from commit 4c1fcee)
Store the selected dag run and task instance with
dag_run_idandtask_idurl params for Grid view.This allowed us to simplify
useSelectionto no longer need useContext. Then I moved some non-components from/treeto/tree/utils^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.