Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow back script_location in Glue to be None #23357

Merged
merged 2 commits into from
Apr 30, 2022

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Apr 29, 2022

Fix error introduced in #20935 where script location in Glue
Job could be None.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

Fix error introduced in apache#20935 where script location in Glue
Job could be None.
Copy link

@JorgenG JorgenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this, I think a not was missed in the elif expression. The first if statement looks good! 👍

airflow/providers/amazon/aws/operators/glue.py Outdated Show resolved Hide resolved
@potiuk
Copy link
Member Author

potiuk commented Apr 29, 2022

I told you are the best person to fix it :)

Copy link

@JorgenG JorgenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 29, 2022
@potiuk potiuk merged commit fa0d934 into apache:main Apr 30, 2022
@potiuk potiuk deleted the fix-optional-script-location-glue branch April 30, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants