Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] remove python 3.6 #23409

Merged
merged 2 commits into from
May 3, 2022
Merged

[FIX] remove python 3.6 #23409

merged 2 commits into from
May 3, 2022

Conversation

raphaelauv
Copy link
Contributor

closes: #23403

@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes kind:documentation labels May 2, 2022
potiuk
potiuk approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label May 2, 2022
@github-actions
Copy link

github-actions bot commented May 2, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

eladkal
eladkal requested changes May 3, 2022
View reviewed changes
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more references:

airflow/docs/apache-airflow/installation/installing-from-pypi.rst

Line 40 in 03bef08

pip install "apache-airflow[celery]==|version|" --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-|version|/constraints-3.6.txt"

better to search also for pattern: constraints-|version|/constraints-3.6.txt

I'm marking this PR with 2.3.1 milestone as our install guide refer to a broken file so we need to fix this in next release
https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-pypi.html#installation-from-pypi

@eladkal eladkal added this to the Airflow 2.3.1 milestone May 3, 2022
@potiuk potiuk force-pushed the fix/remove_python_36 branch from 37b5274 to e8c5925 Compare May 3, 2022 10:10
@potiuk
Copy link
Member

potiuk commented May 3, 2022

I rebaseed it @raphaelauv - there was a fix for Build Docs merged and build docs was hanging for your build, I think the rebase should help

@potiuk potiuk requested a review from eladkal May 3, 2022 12:49
@kaxil
Copy link
Member

kaxil commented May 3, 2022 •
edited
Loading

There are more references:

airflow/docs/apache-airflow/installation/installing-from-pypi.rst

Line 40 in 03bef08

pip install "apache-airflow[celery]==|version|" --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-|version|/constraints-3.6.txt"

better to search also for pattern: constraints-|version|/constraints-3.6.txt

I'm marking this PR with 2.3.1 milestone as our install guide refer to a broken file so we need to fix this in next release https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-pypi.html#installation-from-pypi

We can fix the docs before releasing 2.3.1 too by fixing it in https://github.com/apache/airflow-site/ manually by replacing the 3.6 reference

@potiuk potiuk merged commit af54630 into apache:main May 3, 2022
@potiuk
Copy link
Member

potiuk commented May 3, 2022

Speaking o which @kaxil apache/airflow-site#589 :)

@raphaelauv raphaelauv deleted the fix/remove_python_36 branch May 3, 2022 15:03
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label May 8, 2022
ephraimbuddy pushed a commit that referenced this pull request May 8, 2022
@raphaelauv @ephraimbuddy
[FIX] remove python 3.6 (#23409)
e63f62c 
(cherry picked from commit af54630)
ephraimbuddy pushed a commit that referenced this pull request May 21, 2022
@raphaelauv @ephraimbuddy
[FIX] remove python 3.6 (#23409)
98872ef 
(cherry picked from commit af54630)
@ephraimbuddy ephraimbuddy mentioned this pull request May 21, 2022
Closed
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@kaxil kaxil kaxil approved these changes

@eladkal eladkal eladkal approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@mik-laj mik-laj Awaiting requested review from mik-laj

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

Assignees
No one assigned
Labels
area:dev-tools area:production-image Production image improvements and fixes full tests needed We need to run full set of tests for this PR to merge kind:documentation type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Milestone
Airflow 2.3.1
Development

Successfully merging this pull request may close these issues.

Python 3.6 is still present in the main README
5 participants
@raphaelauv @potiuk @kaxil @eladkal @ephraimbuddy