-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mysql-connector-python
from recommended MySQL driver
#34287
Remove mysql-connector-python
from recommended MySQL driver
#34287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
But I prefer to have the opinions of other people before merging
Not sure about using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I think we should absolutely not use the word "supported" if we don't test it. What we could use is we can make a reference to "You can also attempt to use other drivers. Please consult the SQL Alchemy documentation "
I think it's a but "unfair" to just remove it but, generally moving people out to the place where they can start searching for solution is the best way how we can say "you can try it on your own - see there for details" - this way we delegate it out to SQLAlchemy to describe it "well-enough".
Yeah. And |
Hmm.. we've already have it for MySQL backend If you want to use other drivers visit the `MySQL Dialect <https://docs.sqlalchemy.org/en/13/dialects/mysql.html>`__ in SQLAlchemy documentation for more information regarding download
and setup of the SqlAlchemy connection. About Some quick info about 3 most popular MySQL's DBAPI2 drivers (non-async).
|
Cool. Then I am good. |
Both are fine for me. |
(cherry picked from commit 44831db)
(cherry picked from commit 44831db)
At least from middle of 2019 we run tests only with mysqlclient driver, and I can't find what the initial reason to make mysql-connector-python supported driver for MySQL backend.
In additional in SQLAlchemy documentation
mysql-connector-python
listed (1.4, 2.0) as not tested in their CI with potential unresolved issues.Personally I found this a yet another nice way to shoot in foot or cast wormhole. Maybe I wrong and we should:
mysql-connector-python
so we could say that this actually a supported driver^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.