Fix CI's docs filter generation #35087
Merged
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
requested review from
potiuk,
ashb and
jedcunningham
as code owners
Taragolis
added
the
type:misc/internal
potiuk
approved these changes
Oct 20, 2023
|
Right 🤦 |
|
This case just not happen in main or during full tests that is why we miss that |
Yeah. Who tests the tests. |
|
Enough tests succeeded to merge it. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Oct 21, 2023
The apache#35069 and apache#35087 that switched from `--package-filter` to shorthand package names in CI did not handle all the cases - special package names such as "apache-airflow" or "helm-chart" were treated also as providers and the --package-filter constructed was wrong. This caused a few PRs that got "selective" documentation build (only when they changed provider + some airflow docs) would fail.
potiuk
added a commit
that referenced
this pull request
Oct 21, 2023
The #35069 and #35087 that switched from `--package-filter` to shorthand package names in CI did not handle all the cases - special package names such as "apache-airflow" or "helm-chart" were treated also as providers and the --package-filter constructed was wrong. This caused a few PRs that got "selective" documentation build (only when they changed provider + some airflow docs) would fail.
potiuk
pushed a commit
that referenced
this pull request
Oct 29, 2023
* Fix CI's docs filter generation * Fix test cases (cherry picked from commit fdc443d)
potiuk
added a commit
that referenced
this pull request
Oct 29, 2023
The #35069 and #35087 that switched from `--package-filter` to shorthand package names in CI did not handle all the cases - special package names such as "apache-airflow" or "helm-chart" were treated also as providers and the --package-filter constructed was wrong. This caused a few PRs that got "selective" documentation build (only when they changed provider + some airflow docs) would fail. (cherry picked from commit a562174)
potiuk
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix list generation for
build-docsCI step.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.