Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2-10-test] Fix premature evaluation in mapped task group #44937

Conversation

shahar1
Copy link
Contributor

@shahar1 shahar1 commented Dec 14, 2024

will be ported to main by: #40460
related: #34023


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@shahar1 shahar1 added type:bug-fix Changelog: Bug Fixes area:dynamic-task-mapping AIP-42 labels Dec 14, 2024
@shahar1 shahar1 changed the title [ v2-10-test] Fix premature evaluation in mapped task group [v2-10-test] Fix premature evaluation in mapped task group Dec 14, 2024
@shahar1 shahar1 force-pushed the fix-premature-evaluation-in-mapped-task-group-v2-10-test branch from aa160a6 to aa30d5d Compare December 14, 2024 18:41
@shahar1 shahar1 force-pushed the fix-premature-evaluation-in-mapped-task-group-v2-10-test branch from aa30d5d to 1665c12 Compare December 14, 2024 19:18
@shahar1 shahar1 force-pushed the fix-premature-evaluation-in-mapped-task-group-v2-10-test branch from 1665c12 to b5e426e Compare December 14, 2024 19:49
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kaxil kaxil force-pushed the fix-premature-evaluation-in-mapped-task-group-v2-10-test branch from b5e426e to 268e8d1 Compare December 17, 2024 15:05
@kaxil
Copy link
Member

kaxil commented Dec 17, 2024

@shahar1 Could you verify your changes again -- I needed to force-push on v2-10-test to sync it back with v2-10-stable.

@shahar1
Copy link
Contributor Author

shahar1 commented Dec 17, 2024

@shahar1 Could you verify your changes again -- I needed to force-push on v2-10-test to sync it back with v2-10-stable.

Verified and it works great :)

@shahar1 shahar1 merged commit 4b27c3f into apache:v2-10-test Dec 17, 2024
48 checks passed
@shahar1 shahar1 deleted the fix-premature-evaluation-in-mapped-task-group-v2-10-test branch December 17, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants