Removed the ability for Operators to specify their own "scheduling deps". #45713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
added
airflow3.0:breaking
boring-cyborg
bot
added
area:core-operators
kaxil
approved these changes
Jan 16, 2025
ashb
force-pushed
the
remove-customized-operator-deps
branch
from
751db42 to
3f9a314
Compare
ashb
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
ephraimbuddy
as code owners
jscheffl
reviewed
Jan 16, 2025
| @@ -177,10 +177,6 @@ def serialize(self): | |||
| ) | |||
|
|
|||
|
|
|||
| class UnmappableOperator(AirflowException): | |||
There was a problem hiding this comment.
Oh, did not even know such existed :-D Learning something new every day... ah, now need to have un-seen...
jscheffl
approved these changes
Jan 16, 2025
…ps". This is not talking about the relationship between tasks, but the conditions on an operator that the scheduler checks before it can be schedules -- things like "are my upstreams complete" or "am I out of my retry period" etc) With the split of Task SDK and Task Execution interface this feature has become untennable to support with the split responsibilty mosel, and it is such a rarely used feature that the right approach is to remove it. This makes future code and PRs much much easier.
ashb
force-pushed
the
remove-customized-operator-deps
branch
from
36363c0 to
b95242f
Compare
ashb
added a commit
that referenced
this pull request
Jan 17, 2025
This is removed in Airflow3 via #45713
ashb
added a commit
that referenced
this pull request
Jan 17, 2025
This is removed in Airflow3 via #45713
ashb
added a commit
that referenced
this pull request
Jan 17, 2025
This is removed in Airflow3 via #45713
ashb
added a commit
that referenced
this pull request
Jan 18, 2025
This is removed in Airflow3 via #45713
ashb
added a commit
that referenced
this pull request
Jan 21, 2025
This is removed in Airflow3 via #45713
ashb
added a commit
that referenced
this pull request
Jan 21, 2025
This is removed in Airflow3 via #45713
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
…ps". (apache#45713) This is not talking about the relationship between tasks, but the conditions on an operator that the scheduler checks before it can be schedules -- things like "are my upstreams complete" or "am I out of my retry period" etc) With the split of Task SDK and Task Execution interface this feature has become untennable to support with the split responsibilty mosel, and it is such a rarely used feature that the right approach is to remove it. This makes future code and PRs much much easier.
ashb
added a commit
that referenced
this pull request
Jan 29, 2025
This is removed in Airflow3 via #45713
utkarsharma2
pushed a commit
that referenced
this pull request
Jan 29, 2025
utkarsharma2
added
the
type:misc/internal
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…ps". (apache#45713) This is not talking about the relationship between tasks, but the conditions on an operator that the scheduler checks before it can be schedules -- things like "are my upstreams complete" or "am I out of my retry period" etc) With the split of Task SDK and Task Execution interface this feature has become untennable to support with the split responsibilty mosel, and it is such a rarely used feature that the right approach is to remove it. This makes future code and PRs much much easier.
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not talking about the relationship between tasks, but the conditions
on an operator that the scheduler checks before it can be schedules -- things
like "are my upstreams complete" or "am I out of my retry period" etc)
With the split of Task SDK and Task Execution interface this feature has
become untennable to support with the split responsibilty mosel, and it is
such a rarely used feature that the right approach is to remove it.
This makes future code and PRs much much easier.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.