Fix missing return obj when create-if-not-exist

Signed-off-by: imjoey <[email protected]>
apache · Jan 18, 2021 · a623b98 · a623b98
1 parent 5334111
commit a623b98
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/api/internal/core/store/store.go b/api/internal/core/store/store.go
@@ -284,8 +284,7 @@ func (s *GenericStore) Update(ctx context.Context, obj interface{}, createIfNotE
 	storedObj, ok := s.cache.Load(key)
 	if !ok {
 		if createIfNotExist {
-			_, err := s.Create(ctx, obj)
-			return nil, err
+			return s.Create(ctx, obj)
 		}
 		log.Warnf("key: %s is not found", key)
 		return nil, fmt.Errorf("key: %s is not found", key)

diff --git a/api/test/e2e/ssl_test.go b/api/test/e2e/ssl_test.go
@@ -131,7 +131,7 @@ func TestSSL_Basic(t *testing.T) {
 			}`,
 			Headers:      map[string]string{"Authorization": token},
 			ExpectStatus: http.StatusOK,
-			ExpectBody:   "\"status\": 0",
+			ExpectBody:   "\"status\":0",
 		},
 	}
 
@@ -156,7 +156,7 @@ func TestSSL_Basic(t *testing.T) {
 			Body:         `1`,
 			Headers:      map[string]string{"Authorization": token},
 			ExpectStatus: http.StatusOK,
-			ExpectBody:   "\"status\": 1",
+			ExpectBody:   "\"status\":1",
 		},
 		{
 			Desc:         "hit the route using HTTPS, make sure enable successful",