Skip to content

Commit

Permalink
fix: add data transformer
Browse files Browse the repository at this point in the history
  • Loading branch information
bzp2010 committed Sep 27, 2021
1 parent a733781 commit e98cb17
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 2 deletions.
5 changes: 3 additions & 2 deletions web/src/pages/Service/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
* limitations under the License.
*/
import { request } from 'umi';
import { transformData } from './transform';

export const fetchList = ({ current = 1, pageSize = 10, ...res }) =>
request('/services', {
Expand All @@ -31,13 +32,13 @@ export const fetchList = ({ current = 1, pageSize = 10, ...res }) =>
export const create = (data: ServiceModule.Entity) =>
request('/services', {
method: 'POST',
data,
data: transformData(data),
});

export const update = (serviceId: string, data: ServiceModule.Entity) =>
request(`/services/${serviceId}`, {
method: 'PUT',
data,
data: transformData(data),
});

export const remove = (serviceId: string) =>
Expand Down
31 changes: 31 additions & 0 deletions web/src/pages/Service/transform.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
export const transformData = (data: ServiceModule.Entity): ServiceModule.Entity => {
const newData = data;

if (newData.hosts) {
newData.hosts = newData.hosts.filter((item) => {
return !!item;
});

if (newData.hosts.length <= 0) {
delete newData.hosts;
}
}

return newData;
};
1 change: 1 addition & 0 deletions web/src/pages/Service/typing.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ declare namespace ServiceModule {
type Entity = {
name: string;
desc: string;
hosts?: string[];
upstream: any;
upstream_id: string;
labels: string;
Expand Down

0 comments on commit e98cb17

Please sign in to comment.