Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route.Upstream.Retries field needs to support zero value #2297

Closed
Chaunceyan opened this issue Jan 27, 2022 · 1 comment
Closed

Route.Upstream.Retries field needs to support zero value #2297

Chaunceyan opened this issue Jan 27, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@Chaunceyan
Copy link
Contributor

Issue description

As shown in the doc, the retries field expected zero and null value to behave differently.
But current entity definition omit zero value to empty, so this configuration does not function properly.
image

I am raising PR for this.

Expected behavior

Zero and Null value should be well distinguished.

How to Reproduce

  1. Create Upstream with retries being zero.
  2. View Upstream to see the retries being empty.

Screenshots

image
image
image

Environment

  • apisix version (cmd: apisix version):
  • OS (cmd: uname -a):
  • OpenResty / Nginx version (cmd: nginx -V or openresty -V):
  • etcd version, if have (cmd: run etcd --version):
  • apisix-dashboard version, if have:
  • Browser version, if have:

Additional context

No response

@Chaunceyan Chaunceyan added the bug Something isn't working label Jan 27, 2022
Chaunceyan added a commit to Chaunceyan/apisix-dashboard that referenced this issue Jan 27, 2022
fix issue apache#2297 by changing retries type int to *int
@zaunist
Copy link
Contributor

zaunist commented Feb 6, 2022

@juzhiyuan . We can close this issue after the #2298 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants