Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request help: websocket tab is lost in 2.0rc2? #831

Closed
souzens opened this issue Nov 19, 2020 · 17 comments · Fixed by #1079
Closed

request help: websocket tab is lost in 2.0rc2? #831

souzens opened this issue Nov 19, 2020 · 17 comments · Fixed by #1079
Labels
Milestone

Comments

@souzens
Copy link

souzens commented Nov 19, 2020

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • [yes ] Bug

update to 2.0rc2 . websocket tab is lost in step one。
Has this feature been removed?

@juzhiyuan
Copy link
Member

Ya, from 1.5 to 2.0, we have removed some features which originally belong to plugins, you could find them in plugin page.

@juzhiyuan
Copy link
Member

But note, currently, in plugin page, some of them have UI issues, we are going to resolve all of them in 2.1 soon.

@juzhiyuan juzhiyuan modified the milestones: 2.1, 2.2, 2.3 Nov 19, 2020
@juzhiyuan
Copy link
Member

according to current tasks, this enhancement feature will resolve in 2.3.

@juzhiyuan juzhiyuan added the good first issue Good for newcomers label Nov 24, 2020
@iyuhptop
Copy link

iyuhptop commented Dec 7, 2020

which plugin should select for websocket

@moonming
Copy link
Member

moonming commented Dec 7, 2020

no plugin need weboscket,which is binding with router

@juzhiyuan
Copy link
Member

I see, i will check this ASAP.

@juzhiyuan
Copy link
Member

in Route.

@juzhiyuan
Copy link
Member

image

@juzhiyuan juzhiyuan assigned juzhiyuan and unassigned juzhiyuan Dec 12, 2020
@juzhiyuan
Copy link
Member

https://github.com/apache/apisix/pull/2836/files#diff-ebd29c155b76d68bb1cd728cd626f281f81c62ddb451b345baf2ed8f81480127R378

image

Hi @membphis, I see there has a tip saying the enable_websocket field will be removed soon, do we have any plan?

@moonming
Copy link
Member

moonming commented Dec 13, 2020 via email

@juzhiyuan
Copy link
Member

I couldn't find milestone 2.3, you mean 3.0 or 2.3 has not been created?

https://github.com/apache/apisix/milestones

@juzhiyuan
Copy link
Member

The frontend will still use that field for now.

@moonming
Copy link
Member

moonming commented Dec 13, 2020 via email

@moonming
Copy link
Member

moonming commented Dec 13, 2020 via email

@moonming
Copy link
Member

moonming commented Dec 13, 2020 via email

@juzhiyuan
Copy link
Member

Websocket is binding with route now

Ming Wen [email protected]于2020年12月13日 周日下午6:47写道:

no, FE should not use it in upstream

琚致远 [email protected]于2020年12月13日 周日下午6:30写道:

The frontend will still use that field for now.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#831 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGJZBK7BI4YGKBU36LZLCL3SUSJTVANCNFSM4T3BLYBA
.

--
Thanks,
Ming Wen
Twitter: _WenMing

--
Thanks,
Ming Wen
Twitter: _WenMing

Ok, now i know what happened, i heard from @membphis that this field is bound to Route and called enable_websocket, but when i saw that PR, i didn't see that change is related to upstream_def until you point out.

Conclusion: The frontend will use that field with Route instead of Upstream.

@membphis
Copy link
Member

Conclusion: The frontend will use that field with Route instead of Upstream.

yes, that is right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants