Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: editing a Service, the upstream info will be lost. #1347

Merged
merged 3 commits into from
Jan 24, 2021
Merged

fix: editing a Service, the upstream info will be lost. #1347

merged 3 commits into from
Jan 24, 2021

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Jan 21, 2021

Please answer these questions before submitting a pull request


Bugfix

  • How to fix?
    Change condition upstreamFormData.upstream_id === ‘ ’ to !upstreamFormData.upstream_id

@codecov-io
Copy link

codecov-io commented Jan 21, 2021

Codecov Report

Merging #1347 (8b5dfec) into master (6d7f11a) will decrease coverage by 13.86%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1347       +/-   ##
===========================================
- Coverage   62.79%   48.93%   -13.87%     
===========================================
  Files          41       41               
  Lines        2352     2352               
===========================================
- Hits         1477     1151      -326     
- Misses        700     1008      +308     
- Partials      175      193       +18     
Impacted Files Coverage Δ
api/internal/core/store/query.go 0.00% <0.00%> (-88.10%) ⬇️
api/internal/utils/consts/api_error.go 17.39% <0.00%> (-78.27%) ⬇️
api/internal/core/store/selector.go 0.00% <0.00%> (-75.93%) ⬇️
api/internal/handler/plugin/plugin.go 16.66% <0.00%> (-70.00%) ⬇️
api/internal/core/store/validate_mock.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/filter/authentication.go 44.11% <0.00%> (-32.36%) ⬇️
api/internal/core/store/store.go 59.37% <0.00%> (-28.75%) ⬇️
api/internal/handler/global_rule/global_rule.go 62.71% <0.00%> (-20.34%) ⬇️
api/internal/handler/consumer/consumer.go 74.46% <0.00%> (-17.03%) ⬇️
api/internal/handler/route/route.go 50.43% <0.00%> (-16.96%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7f11a...8b5dfec. Read the comment docs.

@juzhiyuan juzhiyuan requested a review from LiteSun January 23, 2021 12:24
@juzhiyuan juzhiyuan requested a review from liuxiran January 23, 2021 14:21
@LiteSun LiteSun merged commit 5411a1e into apache:master Jan 24, 2021
@juzhiyuan juzhiyuan deleted the fix-create-service branch January 24, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after editing a Service, the upstream info will be lost.
4 participants