Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add script_id field in Route entity #1386

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

imjoey
Copy link
Member

@imjoey imjoey commented Jan 28, 2021

Signed-off-by: imjoey [email protected]

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues

Related to #1085 .


New feature or improvement

  • Describe the details and related test reports.

As discussed in #1085 with @spacewander , this PR is going to add a new field script_id in Route entity to support for debug and optimization(cache) in the future. For now, we could assume that script_id will be always equal to the id of Route entity.


Please add the corresponding test cases if necessary.

Yep, backend tests and backend e2e tests are added.

@imjoey imjoey force-pushed the script_id_in_route branch from 875a8fc to ce65294 Compare January 28, 2021 09:08
Signed-off-by: imjoey <[email protected]>
@imjoey imjoey force-pushed the script_id_in_route branch from ce65294 to 936fac2 Compare January 28, 2021 09:17
@codecov-io
Copy link

Codecov Report

Merging #1386 (936fac2) into master (6ee8dd1) will decrease coverage by 9.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1386      +/-   ##
==========================================
- Coverage   65.48%   55.59%   -9.89%     
==========================================
  Files          44       44              
  Lines        2929     2948      +19     
==========================================
- Hits         1918     1639     -279     
- Misses        782     1051     +269     
- Partials      229      258      +29     
Impacted Files Coverage Δ
api/internal/core/entity/entity.go 100.00% <ø> (ø)
api/internal/handler/route/route.go 66.00% <100.00%> (-11.45%) ⬇️
api/internal/handler/plugin/plugin.go 16.66% <0.00%> (-70.00%) ⬇️
api/internal/core/store/query.go 45.23% <0.00%> (-52.39%) ⬇️
api/internal/core/store/selector.go 35.18% <0.00%> (-51.86%) ⬇️
api/internal/core/store/validate_mock.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/filter/authentication.go 44.11% <0.00%> (-32.36%) ⬇️
api/internal/core/store/store.go 56.96% <0.00%> (-29.10%) ⬇️
api/internal/handler/global_rule/global_rule.go 64.51% <0.00%> (-19.36%) ⬇️
api/internal/handler/consumer/consumer.go 74.46% <0.00%> (-17.03%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ee8dd1...936fac2. Read the comment docs.

@imjoey
Copy link
Member Author

imjoey commented Jan 28, 2021

Thank you @spacewander , and ping @nic-chen @tokers @juzhiyuan for reviewing. Thanks.

@juzhiyuan juzhiyuan merged commit 7b1e3b0 into apache:master Jan 28, 2021
@imjoey imjoey deleted the script_id_in_route branch January 28, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants