-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for -c to set the config file path #1420
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1420 +/- ##
===========================================
- Coverage 67.70% 48.01% -19.69%
===========================================
Files 48 39 -9
Lines 3031 2601 -430
===========================================
- Hits 2052 1249 -803
- Misses 739 1177 +438
+ Partials 240 175 -65
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add test in the /api/test/shell/cli_test.sh
.
api/internal/conf/conf.go
Outdated
@@ -54,6 +54,7 @@ var ( | |||
SSLDefaultStatus = 1 //enable ssl by default | |||
ImportSizeLimit = 10 * 1024 * 1024 | |||
PIDPath = "/tmp/manager-api.pid" | |||
FilePathSet = "/conf/conf.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take care of code style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinayaksh42
You could run go fmt
to format the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay i will do that and make another commit to this pr
FE Test failed and waiting for #1426 |
may sync the latest codes to fix E2E failed. |
Hi, @vinayaksh42 |
same issue @nic-chen |
@ vinayaksh42 need to merge the master branch |
I have merged it. |
ping @nic-chen to check. |
Oh sorry.@vinayaksh42 You need to merge the master branch again. |
need test case for the change |
Hey can you help me with the modification I need to do in order to add a test case for this? |
@vinayaksh42 |
Hi @vinayaksh42, do you meet any problem? |
Could you help to sync codes with this PR? |
Sure, my pleasure. |
I think we can merge it first. |
we need some test cases for it. |
Hi @vinayaksh42, do you need any help from the community? |
ping @vinayaksh42 |
Hey, I am not sure about how to write the test |
Not only need to add tests, but also consider the case where only -c or only -p is specified, or the two parameters are specified together. |
Can you give more details about it? Maybe you can refer https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh. |
ping |
Really sorry for the blockage. I won't be able to contribute since I don't have my dev environment (desktop). If it's okay I would like to close this PR? |
sure, thanks. |
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
This PR fixes issue ManagerAPI should support -c to set the config file. #1406
New feature or improvement
Added support for "-c" in the managerAPI to set the config File path