Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: test make build #1421

Merged
merged 8 commits into from
Feb 5, 2021
Merged

CI: test make build #1421

merged 8 commits into from
Feb 5, 2021

Conversation

gxthrj
Copy link
Contributor

@gxthrj gxthrj commented Feb 4, 2021

Please answer these questions before submitting a pull request

As many commands has been verified in other CI, we only need to check make build.

@codecov-io
Copy link

codecov-io commented Feb 4, 2021

Codecov Report

Merging #1421 (365b835) into master (0a0a42a) will decrease coverage by 9.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1421      +/-   ##
==========================================
- Coverage   66.59%   57.37%   -9.23%     
==========================================
  Files          44       44              
  Lines        2937     2937              
==========================================
- Hits         1956     1685     -271     
- Misses        744      983     +239     
- Partials      237      269      +32     
Impacted Files Coverage Δ
api/internal/handler/plugin/plugin.go 16.66% <0.00%> (-70.00%) ⬇️
api/internal/core/store/query.go 45.23% <0.00%> (-52.39%) ⬇️
api/internal/core/store/selector.go 35.18% <0.00%> (-51.86%) ⬇️
api/internal/core/store/validate_mock.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/filter/authentication.go 44.11% <0.00%> (-32.36%) ⬇️
api/internal/core/store/store.go 60.00% <0.00%> (-26.07%) ⬇️
api/internal/handler/global_rule/global_rule.go 64.51% <0.00%> (-19.36%) ⬇️
api/internal/handler/consumer/consumer.go 74.46% <0.00%> (-17.03%) ⬇️
api/internal/handler/ssl/ssl.go 33.33% <0.00%> (-14.82%) ⬇️
api/internal/utils/json_patch.go 44.82% <0.00%> (-13.80%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0a42a...365b835. Read the comment docs.

@juzhiyuan
Copy link
Member

@gxthrj we should request changes from other members.

@gxthrj gxthrj requested review from juzhiyuan and nic-chen February 4, 2021 02:26
.github/workflows/make-build.yaml Outdated Show resolved Hide resolved
.github/workflows/make-build.yaml Outdated Show resolved Hide resolved
.github/workflows/make-build.yaml Show resolved Hide resolved
@juzhiyuan juzhiyuan changed the title feat: add make build CI CI: test make build Feb 4, 2021
Copy link
Member

@nic-chen nic-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gxthrj you could run the binary and run this script to check the result:
https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/docker_deploy_test.sh

we could rename the script then.

@gxthrj
Copy link
Contributor Author

gxthrj commented Feb 4, 2021

@gxthrj you could run the binary and run this script to check the result:
https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/docker_deploy_test.sh

we could rename the script then.

OK,Thanks, It can check manager-api.

@juzhiyuan
Copy link
Member

image

Not a good name 😂

@juzhiyuan
Copy link
Member

maybe Make build Test?

@gxthrj
Copy link
Contributor Author

gxthrj commented Feb 4, 2021

maybe Make build Test?

OK, Done.

@membphis
Copy link
Member

membphis commented Feb 5, 2021

gxthrj force-pushed the gxthrj:kv/makefile branch from 1e44a66 to f7429f5 2 hours ago

we'd better to use merge + push way, it is better then rebase + push -f

@juzhiyuan
Copy link
Member

yep

@juzhiyuan juzhiyuan merged commit 8e80033 into apache:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] need CI to verify makefile
6 participants