-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: test make build #1421
CI: test make build #1421
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1421 +/- ##
==========================================
- Coverage 66.59% 57.37% -9.23%
==========================================
Files 44 44
Lines 2937 2937
==========================================
- Hits 1956 1685 -271
- Misses 744 983 +239
- Partials 237 269 +32
Continue to review full report at Codecov.
|
@gxthrj we should request changes from other members. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gxthrj you could run the binary and run this script to check the result:
https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/docker_deploy_test.sh
we could rename the script then.
OK,Thanks, It can check manager-api. |
maybe |
OK, Done. |
yep |
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
close [CI] need CI to verify makefile #789
As many commands has been verified in other CI, we only need to check
make build
.