Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite e2e test(upstream_test) with ginkgo #1502

Merged

Conversation

Jaycean
Copy link
Member

@Jaycean Jaycean commented Feb 23, 2021

Please answer these questions before submitting a pull request


New feature or improvement

  • Rewrite e2e test(upstream_test) with ginkgo

@Jaycean Jaycean force-pushed the rewrite_e2e_test_upstream_test_with_ginkgo branch from 237553b to fa02524 Compare February 23, 2021 16:29
@codecov-io
Copy link

codecov-io commented Feb 23, 2021

Codecov Report

Merging #1502 (b43da18) into master (f574fcd) will decrease coverage by 16.79%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1502       +/-   ##
===========================================
- Coverage   68.43%   51.63%   -16.80%     
===========================================
  Files          48       39        -9     
  Lines        3038     2597      -441     
===========================================
- Hits         2079     1341      -738     
- Misses        720     1082      +362     
+ Partials      239      174       -65     
Impacted Files Coverage Δ
api/internal/utils/version.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/filter/request_id.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/entity/entity.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/store/storehub.go 0.00% <0.00%> (-70.41%) ⬇️
api/internal/filter/cors.go 0.00% <0.00%> (-66.67%) ⬇️
api/internal/filter/schema.go 0.00% <0.00%> (-55.47%) ⬇️
api/internal/utils/consts/api_error.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/handler/data_loader/route_import.go 27.41% <0.00%> (-37.50%) ⬇️
api/internal/handler/server_info/server_info.go 57.14% <0.00%> (-33.34%) ⬇️
api/internal/utils/closer.go 0.00% <0.00%> (-33.34%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f574fcd...b43da18. Read the comment docs.

@Jaycean Jaycean force-pushed the rewrite_e2e_test_upstream_test_with_ginkgo branch from fa02524 to c2c651b Compare February 23, 2021 17:20
@juzhiyuan juzhiyuan requested review from nic-chen and starsz February 24, 2021 00:56
api/test/e2enew/upstream/upstream_test.go Outdated Show resolved Hide resolved
api/test/e2enew/upstream/upstream_test.go Outdated Show resolved Hide resolved
api/test/e2enew/upstream/upstream_test.go Outdated Show resolved Hide resolved
@Jaycean
Copy link
Member Author

Jaycean commented Feb 26, 2021

cc @starsz @imjoey @juzhiyuan PTAL. Thks

@nic-chen nic-chen merged commit 10f6044 into apache:master Feb 26, 2021
@Jaycean Jaycean deleted the rewrite_e2e_test_upstream_test_with_ginkgo branch March 2, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants