-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite e2e test(upstream_test) with ginkgo #1502
Merged
nic-chen
merged 6 commits into
apache:master
from
Jaycean:rewrite_e2e_test_upstream_test_with_ginkgo
Feb 26, 2021
Merged
feat: rewrite e2e test(upstream_test) with ginkgo #1502
nic-chen
merged 6 commits into
apache:master
from
Jaycean:rewrite_e2e_test_upstream_test_with_ginkgo
Feb 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaycean
force-pushed
the
rewrite_e2e_test_upstream_test_with_ginkgo
branch
from
February 23, 2021 16:29
237553b
to
fa02524
Compare
Codecov Report
@@ Coverage Diff @@
## master #1502 +/- ##
===========================================
- Coverage 68.43% 51.63% -16.80%
===========================================
Files 48 39 -9
Lines 3038 2597 -441
===========================================
- Hits 2079 1341 -738
- Misses 720 1082 +362
+ Partials 239 174 -65
Continue to review full report at Codecov.
|
Jaycean
force-pushed
the
rewrite_e2e_test_upstream_test_with_ginkgo
branch
from
February 23, 2021 17:20
fa02524
to
c2c651b
Compare
nic-chen
reviewed
Feb 24, 2021
nic-chen
reviewed
Feb 24, 2021
nic-chen
reviewed
Feb 24, 2021
nic-chen
reviewed
Feb 25, 2021
nic-chen
reviewed
Feb 25, 2021
nic-chen
approved these changes
Feb 26, 2021
cc @starsz @imjoey @juzhiyuan PTAL. Thks |
starsz
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Feat: Rewrite all E2E tests using the Ginkgo #1500
New feature or improvement