Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rawDataEditor for route, consumer, upstream and service #1505

Merged
merged 11 commits into from
Feb 25, 2021

Conversation

LiteSun
Copy link
Member

@LiteSun LiteSun commented Feb 24, 2021

Please answer these questions before submitting a pull request


New feature or improvement

  • Describe the details and related test reports.

image

image


Please add the corresponding test cases if necessary.

#1506


Backport patches

  • Why need to backport?

  • Source branch

  • Related commits and pull requests

  • Target branch

@codecov-io
Copy link

codecov-io commented Feb 24, 2021

Codecov Report

Merging #1505 (62aae2a) into master (abaddcd) will decrease coverage by 17.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1505       +/-   ##
===========================================
- Coverage   68.69%   51.63%   -17.07%     
===========================================
  Files          48       39        -9     
  Lines        3038     2597      -441     
===========================================
- Hits         2087     1341      -746     
- Misses        712     1082      +370     
+ Partials      239      174       -65     
Impacted Files Coverage Δ
api/internal/utils/version.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/filter/request_id.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/entity/entity.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/store/storehub.go 0.00% <0.00%> (-70.41%) ⬇️
api/internal/filter/cors.go 0.00% <0.00%> (-66.67%) ⬇️
api/internal/filter/schema.go 0.00% <0.00%> (-55.47%) ⬇️
api/internal/utils/consts/api_error.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/handler/data_loader/route_import.go 27.41% <0.00%> (-37.50%) ⬇️
api/internal/handler/server_info/server_info.go 57.14% <0.00%> (-33.34%) ⬇️
api/internal/utils/closer.go 0.00% <0.00%> (-33.34%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abaddcd...62aae2a. Read the comment docs.

@LiteSun LiteSun changed the title wip: init rawDataEditor component feat: add rawDataEditor for route, consumer, upstream and service Feb 24, 2021
@LiteSun LiteSun marked this pull request as ready for review February 24, 2021 08:03
@LiteSun LiteSun requested a review from juzhiyuan February 24, 2021 14:56
@LiteSun LiteSun requested a review from liuxiran February 25, 2021 01:42
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the typo, we could merge first, but please add the related test cases.

import { useIntl } from 'umi';

type Props = {
visible: boolean,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both visible or readonly is optional, the default value is false.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, both visible and readonly are required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why they are required?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visible: If you set visible to optional, then the user can use this component without passing this variable, then the component will not be displayed.
readonly: Want the user to accurately call the state of the component

web/src/components/RawDataEditor/RawDataEditor.tsx Outdated Show resolved Hide resolved
web/src/components/RawDataEditor/RawDataEditor.tsx Outdated Show resolved Hide resolved
web/src/components/RawDataEditor/RawDataEditor.tsx Outdated Show resolved Hide resolved
web/src/components/RawDataEditor/locales/en-US.ts Outdated Show resolved Hide resolved
web/src/pages/Consumer/List.tsx Show resolved Hide resolved
web/src/pages/Route/List.tsx Outdated Show resolved Hide resolved
web/src/pages/Service/List.tsx Outdated Show resolved Hide resolved
web/src/pages/Upstream/List.tsx Outdated Show resolved Hide resolved
web/src/components/RawDataEditor/RawDataEditor.tsx Outdated Show resolved Hide resolved
@juzhiyuan
Copy link
Member

@LiteSun you could fix those comments in another PR.

@LiteSun
Copy link
Member Author

LiteSun commented Feb 25, 2021

@LiteSun you could fix those comments in another PR.

will fix typo soon in this pr.

@LiteSun LiteSun requested review from nic-chen and starsz February 25, 2021 04:45
@LiteSun LiteSun merged commit b6cb345 into apache:master Feb 25, 2021
@LiteSun LiteSun deleted the feat-raw-editor branch February 25, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants