-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rawDataEditor for route, consumer, upstream and service #1505
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1505 +/- ##
===========================================
- Coverage 68.69% 51.63% -17.07%
===========================================
Files 48 39 -9
Lines 3038 2597 -441
===========================================
- Hits 2087 1341 -746
- Misses 712 1082 +370
+ Partials 239 174 -65
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the typo
, we could merge first, but please add the related test cases.
import { useIntl } from 'umi'; | ||
|
||
type Props = { | ||
visible: boolean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both visible
or readonly
is optional, the default value is false
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, both visible
and readonly
are required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why they are required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
visible
: If you set visible to optional, then the user can use this component without passing this variable, then the component will not be displayed.
readonly
: Want the user to accurately call the state of the component
@LiteSun you could fix those comments in another PR. |
will fix typo soon in this pr. |
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
support to show raw data for Route, Upstream, Service and so on #1399
New feature or improvement
Please add the corresponding test cases if necessary.
#1506
Backport patches
Why need to backport?
Source branch
Related commits and pull requests
Target branch