Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite e2e test(route-with-valid-remote-addr-test) with ginkgo #1560

Conversation

Jaycean
Copy link
Member

@Jaycean Jaycean commented Mar 5, 2021

Please answer these questions before submitting a pull request


New feature or improvement

  • Rewrite e2e test(route-with-valid-remote) with ginkgo

@codecov-io
Copy link

codecov-io commented Mar 5, 2021

Codecov Report

Merging #1560 (81a54a4) into master (9130e09) will decrease coverage by 1.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1560      +/-   ##
==========================================
- Coverage   70.18%   69.12%   -1.07%     
==========================================
  Files         130       49      -81     
  Lines        5340     3164    -2176     
  Branches      549        0     -549     
==========================================
- Hits         3748     2187    -1561     
+ Misses       1344      729     -615     
  Partials      248      248              
Flag Coverage Δ
backend-e2e-test 55.68% <ø> (ø)
backend-e2e-test-ginkgo 39.91% <ø> (+0.31%) ⬆️
backend-unit-test 51.68% <ø> (ø)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Plugin/PluginMarket.tsx
web/src/pages/Plugin/service.ts
web/src/pages/Service/Create.tsx
web/src/components/ActionBar/ActionBar.tsx
web/src/libs/iconfont.js
web/src/global.tsx
web/src/pages/SSL/components/Step1/index.tsx
web/src/pages/Route/List.tsx
...ages/Route/components/DebugViews/DebugDrawView.tsx
.../Route/components/DebugViews/DebugFormDataView.tsx
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9130e09...81a54a4. Read the comment docs.

Copy link
Member

@nic-chen nic-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using table.Entry is better for us, and we could clearly see the comparison before and after the modification.

@Jaycean
Copy link
Member Author

Jaycean commented Mar 8, 2021

Using table.Entry is better for us, and we could clearly see the comparison before and after the modification.

Here also need to create route and replace upstream_ id,table.entry There is no way to create a new variable.

@nic-chen
Copy link
Member

nic-chen commented Mar 8, 2021

Using table.Entry is better for us, and we could clearly see the comparison before and after the modification.

Here also need to create route and replace upstream_ id,table.entry There is no way to create a new variable.

the old test cases are all table driven

@Jaycean
Copy link
Member Author

Jaycean commented Mar 8, 2021

Using table.Entry is better for us, and we could clearly see the comparison before and after the modification.

Here also need to create route and replace upstream_ id,table.entry There is no way to create a new variable.

the old test cases are all table driven

It's my problem. I'll revise it

@nic-chen nic-chen merged commit 39e0370 into apache:master Mar 9, 2021
@nic-chen
Copy link
Member

nic-chen commented Mar 9, 2021

merged. thanks a lot. @Jaycean

@Jaycean Jaycean deleted the rewrite-e2e-test-route-with-valid-remote-addr--test-with-ginkgo branch March 10, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants