-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite e2e test(route_with_uri_uris_test) with ginkgo #1561
feat: rewrite e2e test(route_with_uri_uris_test) with ginkgo #1561
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1561 +/- ##
==========================================
+ Coverage 70.18% 73.24% +3.05%
==========================================
Files 130 86 -44
Lines 5340 2321 -3019
Branches 549 583 +34
==========================================
- Hits 3748 1700 -2048
+ Misses 1344 621 -723
+ Partials 248 0 -248
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using table.Entry
is better for us
Yes, but creating route requires replacing upstream_id |
the old test cases are all table driven... |
It's my problem. I'll revise it |
merged. thanks very much. @Jaycean |
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Feat: Rewrite all E2E tests using the Ginkgo #1500
New feature or improvement