Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite e2e test(rewrite-e2e-test-route-with-prometheus-test) with ginkgo #1613

Conversation

Jaycean
Copy link
Member

@Jaycean Jaycean commented Mar 18, 2021

Please answer these questions before submitting a pull request


New feature or improvement

  • Rewrite e2e test(rewrite-e2e-test-route-with-prometheus-test) with ginkgo

@codecov-io
Copy link

Codecov Report

Merging #1613 (40a68c8) into master (01c9528) will increase coverage by 1.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1613      +/-   ##
==========================================
+ Coverage   71.46%   72.49%   +1.03%     
==========================================
  Files         132       86      -46     
  Lines        5375     2356    -3019     
  Branches      592      592              
==========================================
- Hits         3841     1708    -2133     
+ Misses       1290      648     -642     
+ Partials      244        0     -244     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 72.49% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/helpers.tsx 77.04% <0.00%> (-3.28%) ⬇️
api/internal/route.go
api/internal/log/zap.go
api/internal/handler/ssl/ssl.go
api/internal/handler/data_loader/route_export.go
api/internal/filter/authentication.go
api/internal/core/storage/etcd.go
api/internal/handler/handler.go
api/internal/filter/schema.go
api/internal/handler/route/route.go
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01c9528...40a68c8. Read the comment docs.

Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @Jaycean .

@juzhiyuan juzhiyuan merged commit e687247 into apache:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants