-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Updating docs for e2e tests #1625
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1625 +/- ##
==========================================
- Coverage 71.69% 71.27% -0.42%
==========================================
Files 133 47 -86
Lines 5469 3116 -2353
Branches 592 0 -592
==========================================
- Hits 3921 2221 -1700
+ Misses 1305 652 -653
Partials 243 243
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cc @nic-chen, @juzhiyuan to review when you have time :) Guys, please suggest me a markdown linter, it seems mine is not working😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we put the content of back-end-e2e.md
into back-end-tests.md
?
Thanks, @nic-chen for fixing the lint :) It's really helpful. Definitely! we can merge these docs together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good.Thank you for your contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to update this file:
"items": ["develop", "I18N_USER_GUIDE", "front-end-e2e", "back-end-e2e"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thks.
merged. thanks a lot. @bisakhmondal |
😁 Thank you, everyone, for such wonderful quick reviews. V2.5 💪 |
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
closes Doc: a better doc about how to write and run e2e test and unit test for Backend #1303
closes docker-compose building apisix image is failing (for e2e backend test) #1581
Changes made:
back-end-e2e.md
doc withback-end-tests.md
along with updating the contents.Thanks :)