Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ignore cypress screenshots and videos #1640

Merged
merged 2 commits into from
Mar 23, 2021
Merged

chore: add ignore cypress screenshots and videos #1640

merged 2 commits into from
Mar 23, 2021

Conversation

stu01509
Copy link
Contributor

@stu01509 stu01509 commented Mar 22, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues

New feature or improvement

  • Describe the details and related test reports.
    Add git ignore cypress screenshots and videos

@codecov-io
Copy link

codecov-io commented Mar 22, 2021

Codecov Report

Merging #1640 (50a61ca) into master (6a29034) will decrease coverage by 1.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1640      +/-   ##
==========================================
- Coverage   72.35%   71.02%   -1.34%     
==========================================
  Files         134       47      -87     
  Lines        5737     3116    -2621     
  Branches      665        0     -665     
==========================================
- Hits         4151     2213    -1938     
+ Misses       1342      659     -683     
  Partials      244      244              
Flag Coverage Δ
backend-e2e-test 61.77% <ø> (-0.13%) ⬇️
backend-e2e-test-ginkgo 47.78% <ø> (-0.13%) ⬇️
backend-unit-test 51.77% <ø> (-0.04%) ⬇️
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/storage/etcd.go 43.63% <0.00%> (-3.64%) ⬇️
api/internal/core/store/store.go 87.34% <0.00%> (-0.61%) ⬇️
web/src/pages/Plugin/List.tsx
.../src/pages/User/components/LoginMethodPassword.tsx
web/src/pages/Route/service.ts
web/src/pages/Consumer/service.ts
web/src/pages/Route/components/Step2/index.tsx
web/src/pages/Plugin/PluginMarket.tsx
web/src/pages/User/Logout.tsx
...eb/src/components/PluginOrchestration/transform.ts
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a29034...50a61ca. Read the comment docs.

Copy link
Member

@bisakhmondal bisakhmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juzhiyuan juzhiyuan requested review from LiteSun and nic-chen March 22, 2021 23:34
@LiteSun LiteSun merged commit eecadb8 into apache:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants