Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change the metrics to dashboard #1641

Merged
merged 3 commits into from
Mar 23, 2021
Merged

feat: change the metrics to dashboard #1641

merged 3 commits into from
Mar 23, 2021

Conversation

stu01509
Copy link
Contributor

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues
    Fix improve Metrics module #1627

New feature or improvement

  • Describe the details and related test reports.

Please add the corresponding test cases if necessary.

Change the metrics to dashboard, and adjust the dashboard tip content.

image

image

web/config/routes.ts Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Mar 22, 2021

Codecov Report

Merging #1641 (702b92c) into master (968c15f) will decrease coverage by 9.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1641      +/-   ##
==========================================
- Coverage   71.18%   61.87%   -9.31%     
==========================================
  Files          47       47              
  Lines        3116     3116              
==========================================
- Hits         2218     1928     -290     
- Misses        654      876     +222     
- Partials      244      312      +68     
Flag Coverage Δ
backend-e2e-test 61.87% <ø> (-0.04%) ⬇️
backend-e2e-test-ginkgo 47.81% <ø> (-0.23%) ⬇️
backend-unit-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/utils/runtime/runtime.go 0.00% <0.00%> (-64.29%) ⬇️
api/internal/core/store/validate_mock.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/filter/authentication.go 47.22% <0.00%> (-30.56%) ⬇️
api/internal/handler/service/service.go 62.60% <0.00%> (-29.57%) ⬇️
api/internal/core/store/store.go 58.43% <0.00%> (-29.52%) ⬇️
api/internal/filter/ip_filter.go 48.71% <0.00%> (-23.08%) ⬇️
api/internal/handler/global_rule/global_rule.go 64.51% <0.00%> (-19.36%) ⬇️
...pi/internal/handler/plugin_config/plugin_config.go 59.57% <0.00%> (-18.09%) ⬇️
api/internal/utils/json_patch.go 44.82% <0.00%> (-13.80%) ⬇️
api/internal/handler/upstream/upstream.go 77.14% <0.00%> (-13.58%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 968c15f...702b92c. Read the comment docs.

web/src/locales/zh-CN/menu.ts Outdated Show resolved Hide resolved
@juzhiyuan juzhiyuan requested a review from liuxiran March 23, 2021 02:02
@starsz starsz merged commit 2f5d27c into apache:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve Metrics module
7 participants