-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change the metrics to dashboard #1641
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu01509
commented
Mar 22, 2021
stu01509
commented
Mar 22, 2021
stu01509
commented
Mar 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #1641 +/- ##
==========================================
- Coverage 71.18% 61.87% -9.31%
==========================================
Files 47 47
Lines 3116 3116
==========================================
- Hits 2218 1928 -290
- Misses 654 876 +222
- Partials 244 312 +68
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
juzhiyuan
approved these changes
Mar 22, 2021
nic-chen
approved these changes
Mar 22, 2021
LiteSun
approved these changes
Mar 23, 2021
starsz
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Fix improve Metrics module #1627
New feature or improvement
Please add the corresponding test cases if necessary.
Change the
metrics
todashboard
, and adjust the dashboard tip content.