-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite e2e test route with plugin orchestration test with ginkgo #1663
feat: rewrite e2e test route with plugin orchestration test with ginkgo #1663
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1663 +/- ##
==========================================
- Coverage 72.53% 62.76% -9.77%
==========================================
Files 134 125 -9
Lines 5738 5272 -466
Branches 666 666
==========================================
- Hits 4162 3309 -853
- Misses 1333 1775 +442
+ Partials 243 188 -55
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks.
func TestRoute_With_Plugin_Orchestration(t *testing.T) { | ||
bytes, err := ioutil.ReadFile("../testdata/dag-conf.json") | ||
assert.Nil(t, err) | ||
var _ = ginkgo.Describe("route with plugin orchestration", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test cases here only check the admin API, but not concerned about the data use in DP, it's not a closed loop, we may request DP to verify DP's behaviors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Feat: Rewrite all E2E tests using the Ginkgo #1500
New feature or improvement