Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved plugin #1631 #1674

Merged
merged 2 commits into from
Apr 1, 2021
Merged

feat: improved plugin #1631 #1674

merged 2 commits into from
Apr 1, 2021

Conversation

iamayushdas
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Plugin TODO

  • Search area, using Table's own, using fuzzy search.
  • page title not internationalized: configure global plugins/Configure Global Plugin.
  • Add icon for Plugin Marketplace plugins.
  • list page top title, add description: list of enabled plugins.
  • list page, edit button in action area modified to: 配置/Configure.

Plugin Editor

  • Some Auth plugins do not need to be configured, in the Data Editor, to disable the input of content.
  • The button is not internationalized.
  • Document button fits too close to JSON button.
  • JSONSchema checks for error messages, which can be divided into: error message + view details.
  • CodeMirror code error highlighting.

Meta Raw data editor (Route List page)

  • Button not internationalized.
  • layout needs to be adjusted, with additional scrolling axes.

Extras: Dashboard title also internationalised

Related issues

fix/resolve #1631

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

screencapture-172-20-10-3-8000-plugin-list-2021-03-26-08_32_08

screencapture-172-20-10-3-8000-plugin-list-2021-03-26-08_19_00

screencapture-172-20-10-3-8000-plugin-list-2021-03-26-08_33_35

@juzhiyuan
Copy link
Member

@nic-chen @starsz Plz take a look at the failed CI.

@nic-chen
Copy link
Member

@nic-chen @starsz Plz take a look at the failed CI.

It may be because apisix-docker failed to start.
This problem has been fixed:
apache/apisix-docker#154

I ran again to take a look.

@iamayushdas
Copy link
Contributor Author

iamayushdas commented Mar 26, 2021

@nic-chen @juzhiyuan @LiteSun @guoqqqi can i have the review please?

@juzhiyuan
Copy link
Member

@iamayushdas of course! Everyone could review PRs in our community :)

@juzhiyuan
Copy link
Member

Just review & comment if needed :)

@iamayushdas
Copy link
Contributor Author

@iamayushdas of course! Everyone could review PRs in our community :)

I meant ,Can you review this for approval

@juzhiyuan
Copy link
Member

got it, please be patient for GitHub is not realtime always :)

@nic-chen
Copy link
Member

@nic-chen @juzhiyuan @LiteSun @guoqqqi can i have the review please?

sorry, I am not familiar with the front-end codes and can't review it for you

@iamayushdas
Copy link
Contributor Author

@liuxiran please review this

@juzhiyuan
Copy link
Member

Hi, @LiteSun @Jaycean @liuxiran @bzp2010 Please view this one first, once that gets merged, @iamayushdas Please update this branch to latest.

#1685

@Jaycean
Copy link
Member

Jaycean commented Apr 1, 2021

@iamayushdas Please update the branch to resolve the code conflict.

@iamayushdas
Copy link
Contributor Author

@juzhiyuan all approvals are done now, you can merge it

@juzhiyuan juzhiyuan merged commit d946005 into apache:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve Plugin & Plugin Editor & Meta Raw Data Editor module
6 participants