-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: autocomplete when people input http header #1679
Conversation
Wow! Good feature indeed! @qian0817 Would you like to write the test cases for this PR? or need some help about this? BTW, please update the Checklist :) |
also cc @guoqqqi to review |
@juzhiyuan I dont't konw how to use cypress,so I may need some help to write test case. |
I'm confused why the behavior of component input and autocomplete appear inconsistent when delete form item. 🤔 |
fix the problem that the form is displayed incorrectly when the delete button is clicked in the online debugging view. Modify the code according to antd documentation. https://ant.design/components/form-cn/#components-form-demo-dynamic-form-item
@guoqqqi fixed |
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
==========================================
+ Coverage 72.41% 74.09% +1.67%
==========================================
Files 133 86 -47
Lines 5728 2617 -3111
Branches 666 667 +1
==========================================
- Hits 4148 1939 -2209
+ Misses 1337 678 -659
+ Partials 243 0 -243
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
LGTM! Hi, I can help you to add an E2E test to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and you could ask @guoqqqi for help to write E2E.
@guoqqqi Hi,How to simulate clicking on the prompt part of the autocomplete component.I tried to use the following code but not work. it('sample', function () {
cy.visit('/');
cy.contains(menuLocaleUS['menu.routes']).click();
const currentToken = localStorage.getItem('token');
cy.contains(routeLocaleUS['page.route.onlineDebug']).click();
cy.get(domSelector.debugDraw).should('be.visible');
cy.get(domSelector.headerTab).should('be.visible').click();
cy.get(domSelector.headerDataKey0).type('auth').click();
cy.contains(domSelector.headerAuthorizationKey).click()
cy.get(domSelector.headerDataValue0).type(currentToken);
}); |
Hi, @qian0817 You can solve this problem like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
autocomplete when people input http header
Related issues
None
Checklist: