Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove proxy-rewrite plugin out of create plugin template config view #1723

Merged
merged 4 commits into from
Apr 11, 2021
Merged

fix: remove proxy-rewrite plugin out of create plugin template config view #1723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12fd728
fix: remote proxy-rewrite plugin out of plugin template config vlew
liuxiran Apr 8, 2021
968e206
test: add test case
liuxiran Apr 8, 2021
f4886d9
Update Create.tsx
juzhiyuan Apr 9, 2021
d7a3adf
fix: fix review
liuxiran Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ context('Create Configure and Delete PluginTemplate', () => {

cy.get(this.domSelector.description).type(this.data.pluginTemplateName);
cy.contains('Next').click();

// should not see proxy-rewrite plugin in the step2
cy.contains('proxy-rewrite').should('not.exist');

cy.contains('Enable').click({
force: true
});
Expand Down
7 changes: 6 additions & 1 deletion web/src/pages/PluginTemplate/Create.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,12 @@ const Page: React.FC = (props) => {

{step === 1 && <Step1 form={form1} />}
{step === 2 && (
<PluginPage initialData={plugins} onChange={setPlugins} schemaType="route" />
<PluginPage
juzhiyuan marked this conversation as resolved.
Show resolved Hide resolved
initialData={plugins}
onChange={setPlugins}
referPage="route"
schemaType="route"
/>
)}
{step === 3 && <Preview form1={form1} plugins={plugins} />}
</Card>
Expand Down