Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api-breaker plugin form #1730

Merged
merged 15 commits into from
Apr 14, 2021

Conversation

LiteSun
Copy link
Member

@LiteSun LiteSun commented Apr 9, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
Add api-breaker plugin form.
image

Related issues

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-io
Copy link

codecov-io commented Apr 10, 2021

Codecov Report

Merging #1730 (872ccf6) into master (419128d) will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1730      +/-   ##
==========================================
- Coverage   72.57%   72.50%   -0.08%     
==========================================
  Files         113      114       +1     
  Lines        2695     2724      +29     
  Branches      650      659       +9     
==========================================
+ Hits         1956     1975      +19     
- Misses        739      749      +10     
Flag Coverage Δ
frontend-e2e-test 72.50% <66.66%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/UI/api-breaker.tsx 62.96% <62.96%> (ø)
web/src/components/Plugin/UI/plugin.tsx 69.23% <100.00%> (+5.59%) ⬆️
web/src/helpers.tsx 68.85% <0.00%> (-3.28%) ⬇️
...ages/Route/components/DebugViews/DebugDrawView.tsx 79.86% <0.00%> (+1.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419128d...872ccf6. Read the comment docs.

web/src/components/Plugin/UI/api-breaker.tsx Show resolved Hide resolved
web/src/components/Plugin/UI/api-breaker.tsx Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Apr 12, 2021

Deploy preview for apisix-dashboard ready!

Built with commit a023f82

https://deploy-preview-1730--apisix-dashboard.netlify.app

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No urgent changes need to be updated, but those comments should resolve in the new PR.

name="break_response_code"
rules={[{
required: true,
message: `${formatMessage({ id: 'component.global.pleaseEnter' })} break_response_code`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n

<Form.Item
label="max_breaker_sec"
name="max_breaker_sec"
initialValue={300}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use initialValue here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use as default value.

initialValue={300}
tooltip={formatMessage({ id: 'component.pluginForm.api-breaker.max_breaker_sec.tooltip' })}
>
<InputNumber min={60} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LiteSun this one.

@juzhiyuan juzhiyuan merged commit b6a175f into apache:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants