-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add api-breaker plugin form #1730
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1730 +/- ##
==========================================
- Coverage 72.57% 72.50% -0.08%
==========================================
Files 113 114 +1
Lines 2695 2724 +29
Branches 650 659 +9
==========================================
+ Hits 1956 1975 +19
- Misses 739 749 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Deploy preview for apisix-dashboard ready! Built with commit a023f82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No urgent changes need to be updated, but those comments should resolve in the new PR.
name="break_response_code" | ||
rules={[{ | ||
required: true, | ||
message: `${formatMessage({ id: 'component.global.pleaseEnter' })} break_response_code` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i18n
<Form.Item | ||
label="max_breaker_sec" | ||
name="max_breaker_sec" | ||
initialValue={300} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use initialValue here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use as default value.
initialValue={300} | ||
tooltip={formatMessage({ id: 'component.pluginForm.api-breaker.max_breaker_sec.tooltip' })} | ||
> | ||
<InputNumber min={60} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LiteSun this one.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Add api-breaker plugin form.
Related issues
Checklist: