feat: added cors plugin form #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1733 +/- ##
===========================================
- Coverage 72.45% 52.25% -20.20%
===========================================
Files 132 38 -94
Lines 5721 2660 -3061
Branches 649 0 -649
===========================================
- Hits 4145 1390 -2755
+ Misses 1334 1082 -252
+ Partials 242 188 -54
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
actually, the Form style needs to be updated. You could split it into 2 issues:
|
juzhiyuan
reviewed
Apr 11, 2021
|
Deploy preview for apisix-dashboard ready! Built with commit 4138c5b |
juzhiyuan
reviewed
Apr 11, 2021
juzhiyuan
reviewed
Apr 12, 2021
juzhiyuan
approved these changes
Apr 14, 2021
| <Form | ||
| form={form} | ||
| {...FORM_ITEM_LAYOUT} | ||
| initialValues={{ allow_origins_by_regex: [''] }} |
There was a problem hiding this comment.
Why only add initial values for this field here?
| 'component.pluginForm.cors.allow_origins.extra': 'For example: https://somehost.com:8081', | ||
| 'component.pluginForm.cors.allow_methods.tooltip': 'Which Method is allowed to enable CORS, such as: GET, POST etc. Multiple method use , to split. When allow_credential is false, you can use * to indicate allow all any method. You also can allow any method forcefully using ** even already enable allow_credential, but it will bring some security risks.', | ||
| 'component.pluginForm.cors.allow_headers.tooltip': 'Which headers are allowed to set in request when access cross-origin resource. Multiple value use , to split. When allow_credential is false, you can use * to indicate allow all request headers. You also can allow any header forcefully using ** even already enable allow_credential, but it will bring some security risks.', | ||
| 'component.pluginForm.cors.expose_headers.tooltip': ' Which headers are allowed to set in response when access cross-origin resource. Multiple value use , to split.', |
| <Select | ||
| mode="multiple" | ||
| optionLabelProp="label" | ||
| onChange={(value) => { |
There was a problem hiding this comment.
Suggested change
| onChange={(value) => { | |
| onChange={(value: string[]) => { |
| <Switch /> | ||
| </Form.Item> | ||
|
|
||
| <Form.List name={['allow_origins_by_regex']}> |
There was a problem hiding this comment.
Suggested change
| <Form.List name={['allow_origins_by_regex']}> | |
| <Form.List name="allow_origins_by_regex"> |
LiteSun
approved these changes
Apr 14, 2021
moonming
approved these changes
Apr 15, 2021
Yiyiyimu
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
added cors plugin form
What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/resolve #1
Checklist: