Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support SPA 404 fallback #1750

Merged
merged 4 commits into from
Apr 12, 2021
Merged

chore: support SPA 404 fallback #1750

merged 4 commits into from
Apr 12, 2021

Conversation

juzhiyuan
Copy link
Member

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Hi, the web is a Single Page Application, and we use Netlify to deliver it. When we visiting the Preview page & refresh, it will throw 404 pages, that's the natural behavior of SPA. This PR aims to support 404 fallbacks, so we could refresh as other web applications.

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

chore: improve Route module (apache#1715)
fix: When editing a route, the "URI override" radio button‘s value is…
@netlify
Copy link

netlify bot commented Apr 11, 2021

Deploy preview for apisix-dashboard ready!

Built with commit a127f63

https://deploy-preview-1750--apisix-dashboard.netlify.app

@Yiyiyimu Yiyiyimu merged commit afc3df9 into apache:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants